Fix build break when building RISCVInstrInfo.cpp with MSVC #110342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-backend-risc-v Author: Daniel Paoliello (dpaoliello) ChangesAfter #109774 MSVC is failing to build LLVM with the error: Fix is ensure that the RHS is an unsigned integer. Full diff: https://github.com/llvm/llvm-project/pull/110342.diff 1 Files Affected:
diff --git a/llvm/lib/Target/RISCV/RISCVInstrInfo.cpp b/llvm/lib/Target/RISCV/RISCVInstrInfo.cpp
index f0295d289ed86a..529944044f02d2 100644
--- a/llvm/lib/Target/RISCV/RISCVInstrInfo.cpp
+++ b/llvm/lib/Target/RISCV/RISCVInstrInfo.cpp
@@ -779,7 +779,7 @@ MachineInstr *RISCVInstrInfo::foldMemoryOperandImpl(
if (RISCV::getRVVMCOpcode(MI.getOpcode()) == RISCV::VMV_X_S) {
unsigned Log2SEW =
MI.getOperand(RISCVII::getSEWOpNum(MI.getDesc())).getImm();
- if (STI.getXLen() < (1 << Log2SEW))
+ if (STI.getXLen() < (1U << Log2SEW))
return nullptr;
switch (Log2SEW) {
case 3:
|
Contributor
|
Thanks for fixing this. What version of MSVC was this showing up with? This seemed to slip past the windows pre-merge CI: https://buildkite.com/llvm-project/github-pull-requests/builds/103512#0192235b-a71e-4dc7-8b7b-6ba3b185f6ac |
lukel97
approved these changes
Sep 29, 2024
Contributor
Author
|
Looks like CI is running VS 2019: And I'm using VS 2022: |
steven-studio
pushed a commit
to steven-studio/llvm-project
that referenced
this pull request
Sep 11, 2025
After llvm#109774 MSVC is failing to build LLVM with the error: ``` llvm\lib\Target\RISCV\RISCVInstrInfo.cpp(782): warning C4018: '<': signed/unsigned mismatch ``` Fix is ensure that the RHS is an unsigned integer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #109774 MSVC is failing to build LLVM with the error:
Fix is ensure that the RHS is an unsigned integer.